Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Open Support #57

Open
slabgames opened this issue Nov 2, 2024 · 4 comments
Open

App Open Support #57

slabgames opened this issue Nov 2, 2024 · 4 comments

Comments

@slabgames
Copy link

Will there be support for app open ads?

@MAJigsaw77
Copy link
Contributor

I've recently made a fork of this library which rewrites everything and also adds app open ads

https://github.com/MAJigsaw77/extension-admob

@pozirk
Copy link
Member

pozirk commented Dec 18, 2024

Hey @MAJigsaw77,
Lots of great improvements comparing to the current version.
Could you maybe keep the original syntax of the extension so we can merge your modifications?
Like keep Admob.showBanner(...) instead of having admob.Admob.showBanner(..), etc?
Thank you.

@MAJigsaw77
Copy link
Contributor

Hey @MAJigsaw77, Lots of great improvements comparing to the current version. Could you maybe keep the original syntax of the extension so we can merge your modifications? Like keep Admob.showBanner(...) instead of having admob.Admob.showBanner(..), etc? Thank you.

Alright, I'll try to make some changes so i can pr it.

@slabgames
Copy link
Author

I also made some changes to make it work with NME
https://github.com/slabgames/extension-admob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants