Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double histograms #39

Open
Licenser opened this issue Dec 18, 2016 · 2 comments
Open

Double histograms #39

Licenser opened this issue Dec 18, 2016 · 2 comments

Comments

@Licenser
Copy link

I'm curious why double histograms are 'not likely to be implemented'. No criticism just wonder if it's a technical issue, simply no personal need for them, a strong distaste for doubles (which I can totally sympathise with)? Would a PR to that end be accepted (can't guarantee I'll make one as my c is not strong, but I might try)?

@mikeb01
Copy link
Contributor

mikeb01 commented Dec 23, 2016

Abstracting the counter type (int, long, double) is tricker in C than the other supported languages (Java, etc). It would require either some macro-fu and a complete re-implementation for the alternative data types. This would either complicate the existing implementation or require a significant amount of duplicate work. Given that no one has asked for it and I don't have a use for it, it felt like a significant cost for very little value.

If you wanted to implement it, then the second option would be preferable as it would not complicate the existing implementation.

However, it you are looking at making a contribution a more pressing feature is dynamically reallocating/resizing the counts array. The Java version has this feature.

@Licenser
Copy link
Author

Hi Mike,
thanks for the reply. My interest at the moment is especially about the float part, as it's something I need :) but I totally understand that it's no interest. I'll fork and see what I can do with changing the implementation over to floats.

Cheers,
Heinz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants