cmd/outdated: display warning for disabled casks #17124
Conversation
I think formulae just do this on Doing so on |
|
To be clear, are you suggesting not listing these on From memory one of the main motivators for adding deprecate/disable to Casks was that we could then alert users when something they have installed becomes disabled. Otherwise I don't see a significant benefit over just removing them how we used to. My concern is that it does become too naggy if it shows all the time, and in cases where the user would like to keep the application but not the Caskfile, we may need a way to remove it from Homebrew without removing the application? |
Yes (and before that My main consideration is: let's be consistent with what we do for formulae and casks. |
|
Thanks @MikeMcQuaid - a list of disabled casks/formula is already being output when running I can re-work this PR to include some output when running |
Thanks for checking!
I don't have strong feelings about whether we do either or both. If we do outdated: probably need to think about how @Homebrew/maintainers any thoughts here on how we are more noisy about deprecated formulae/casks? |
| if args.named.present? | ||
| select_disabled(args.named.to_casks) | ||
| else | ||
| select_disabled(Cask::Caskroom.casks) |
There was a problem hiding this comment.
Can you use hyperfine to see how much slower this makes the default brew outdated?
| @@ -78,6 +78,7 @@ def run | |||
| end | |||
|
|
|||
| print_outdated(outdated) | |||
| print_disabled(disabled_casks) | |||
There was a problem hiding this comment.
As mentioned: if we output casks here: we should also output formulae. May also want to think about how --json is handled.
|
Waiting to see if anybody had any thoughts here before going any further, but if there's no appetite for more warnings, I'm okay to leave it for now. |
| casks.each do |cask| | ||
| opoo "#{cask.token} is #{DeprecateDisable.message(cask)}" | ||
| end | ||
| puts "Consider looking for alternatives, as they will be removed from Homebrew soon." |
There was a problem hiding this comment.
Need to handle this (and probably also the opoo above differently when STDOUT is not a TTY e.g. compare brew outdated and brew outdated | cat output.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
I still have this on my radar, but probably won't get to it for a couple of weeks, so happy for this to close and reopen when I have some more time. |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This is an initial pass at warning users when they have casks installed that are disabled so that they can consider alternatives, and be alerted that a cask is leaving soon.
I am not 100% sure on the best place to position the warning yet, so the first option here is to show the list when running
brew outdated. I'm not sure if this should be behind a flag, but it should probably be suppressed with the--quietflag. The other location could be when runningbrew upgradeorbrew update, but I'm hesitant for it to be too naggy.