Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort list of '--version'ed casks. #18996

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

ascherer
Copy link
Contributor

@ascherer ascherer commented Dec 24, 2024

See issue Homebrew/homebrew-cask#196331

brew list --cask --version produces an unsorted list of installed casks.

Also, the casks part of brew list --versions is unsorted, while the formulas are (still) sorted.

This regression was introduced by this commit.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@ascherer ascherer force-pushed the sort-casks-with-versions branch from 3e7e58c to a52af89 Compare December 24, 2024 12:58
'brew list --cask --version' produces an unsorted list.

Also, the cask part of 'brew list --version' is unsorted, while the
formulas are (still) sorted.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @ascherer!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 24, 2024
@MikeMcQuaid
Copy link
Member

Also: thanks for your first PR @ascherer, you rock!

Merged via the queue into Homebrew:master with commit 882bb52 Dec 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants