Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1602: prereq for updating existing locks #6590

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jombooth
Copy link
Contributor

@jombooth jombooth commented Nov 1, 2024

Supersedes #6583 - created_at is needed for implementation of task expiry updating function, and this version is safer than using auto_now_add on a new field for an existing table. The sql/redis migration has been taken directly from that PR

@github-actions github-actions bot added the feat label Nov 1, 2024
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit ef99009
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/672531667e38b70008880858

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit ef99009
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/672531663679490008b1f8f1

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (656fdfd) to head (ef99009).
Report is 194 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/tasks/models.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6590   +/-   ##
========================================
  Coverage    76.73%   76.73%           
========================================
  Files          169      169           
  Lines        13819    13826    +7     
========================================
+ Hits         10604    10610    +6     
- Misses        3215     3216    +1     
Flag Coverage Δ
pytests 76.73% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@triklozoid
Copy link
Contributor

It doesn't fit requirement:
Screenshot_2024-11-04_10-04-46

@robot-ci-heartex
Copy link
Collaborator

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants