Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OPTIC-1360: [BE] create Account settings endpoints that handle existing functionality in the django template #6736

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

mcanu
Copy link
Contributor

@mcanu mcanu commented Nov 29, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Adding endpoint for getting the needed information about a user in an organization for the new Settings page.

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

…existing functionality in the django template
@github-actions github-actions bot added the feat label Nov 29, 2024
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit d3b3e8d
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6750ac72c03e090008b12c5b
😎 Deploy Preview https://deploy-preview-6736--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit d3b3e8d
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6750ac72dbac2e00085ac2a6
😎 Deploy Preview https://deploy-preview-6736--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mcanu mcanu marked this pull request as ready for review November 29, 2024 20:57
@mcanu mcanu marked this pull request as draft November 29, 2024 21:03
@mcanu mcanu marked this pull request as ready for review December 2, 2024 20:49
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (05eaf86) to head (d3b3e8d).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6736      +/-   ##
===========================================
+ Coverage    76.70%   76.77%   +0.06%     
===========================================
  Files          170      170              
  Lines        13919    13944      +25     
===========================================
+ Hits         10677    10705      +28     
+ Misses        3242     3239       -3     
Flag Coverage Δ
pytests 76.77% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot-ci-heartex robot-ci-heartex self-requested a review December 3, 2024 17:53
@wesleylima
Copy link
Contributor

Left a small question but overall looks great! Good job @mcanu !

@robot-ci-heartex robot-ci-heartex enabled auto-merge (squash) December 4, 2024 19:16
auto-merge was automatically disabled December 4, 2024 19:20

Pull request was closed

@mcanu mcanu reopened this Dec 4, 2024
@mcanu
Copy link
Contributor Author

mcanu commented Dec 4, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/frontend-test/src/helpers/utils/fixLSParams.ts

@mcanu mcanu merged commit 83ee25a into develop Dec 4, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants