Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: OPTIC-1061: Improve webpack bundle management so bundles can be cached more effectively #6797

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Dec 17, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Defining app css block so it can be overridden upstream for redefinition of assets.

@github-actions github-actions bot added the chore label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit b63bd6c
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67617e4d04e2ad0008e4780e

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit b63bd6c
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67617e4dec3d660008b50e17

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (4dd9e7a) to head (b63bd6c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/utils/manifest_assets.py 56.25% 7 Missing ⚠️
label_studio/core/utils/static_serve.py 25.00% 6 Missing ⚠️
label_studio/core/templatetags/filters.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6797      +/-   ##
===========================================
- Coverage    76.83%   76.77%   -0.06%     
===========================================
  Files          170      171       +1     
  Lines        13994    14021      +27     
===========================================
+ Hits         10752    10765      +13     
- Misses        3242     3256      +14     
Flag Coverage Δ
pytests 76.77% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@bmartel bmartel merged commit dfa7932 into develop Dec 17, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants