Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version reported for Aoe_TemplateHints module #78

Open
aadmathijssen opened this issue Jun 8, 2018 · 4 comments
Open

Incorrect version reported for Aoe_TemplateHints module #78

aadmathijssen opened this issue Jun 8, 2018 · 4 comments

Comments

@aadmathijssen
Copy link

The latest version of the Aoe_Templatehints module is 0.4.3 (according toe the config.xml), but the hypernode:modules:list-updates command outputs the following:

+-------------------+-----------+-----------------+----------------+--------+--------------------------+
| Name              | Code pool | Current version | Latest version | Status | Newer version available? |
+-------------------+-----------+-----------------+----------------+--------+--------------------------+
| Aoe_TemplateHints | community | 0.4.3           | 0.6.0          | active | Yes                      |
+-------------------+-----------+-----------------+----------------+--------+--------------------------+

Is it possible to remove this false positive?

Thanks.

@peterjaap
Copy link
Collaborator

The reason why this happens is because Byte 'crowd-sources' the version numbers by parsing all app/etc/modules/*.xml files. If somebody forks an extension and keeps the name but ups the version number, this will create a false positive.

Maybe Byte can implement a mechanism that filters out version numbers that only occur once across all codebases?

@vdloo
Copy link
Member

vdloo commented Jun 8, 2018

@vdloo
Copy link
Member

vdloo commented Jun 8, 2018

I've manually set this one back to 0.4.3 for now, that should remove the false positive temporary. but yes we should definitely make something to make this less error-prone

127.0.0.1:6379> HGET magmodules Aoe_TemplateHints
"0.6.0"
127.0.0.1:6379> HSET magmodules Aoe_TemplateHints 0.4.3
(integer) 0
127.0.0.1:6379> HGET magmodules Aoe_TemplateHints
"0.4.3"

@aadmathijssen
Copy link
Author

Nice, thanks for the quick reply, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants