Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation banner should take into account the request strategy used #18

Open
dwosk opened this issue Apr 6, 2022 · 0 comments
Open
Assignees

Comments

@dwosk
Copy link
Member

dwosk commented Apr 6, 2022

The two-step banner was designed in mind that the web extension strategy would be used. However, the HTTP strategy can be used by setting connectMethod: 'http'. In this case, the UI should not show "Install Extension" since it is not actually required. We used to have the "blue" banner to handle the HTTP strategy, but we've since removed it from the SDK.

We should update the UI to handle the HTTP strategy properly. This will become more important if/when we make the HTTP strategy the default again and mitigate the need for a web extension since mainstream browsers (mainly Chrome/Firefox) now treat HTTP requests to 127.0.0.1 as secure.

@dwosk dwosk self-assigned this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant