Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importSBML no longer working in current MATLAB version #2

Closed
thomassligon opened this issue Oct 29, 2022 · 5 comments
Closed

importSBML no longer working in current MATLAB version #2

thomassligon opened this issue Oct 29, 2022 · 5 comments

Comments

@thomassligon
Copy link
Collaborator

This was AMICI-dev/AMICI#1875.

In MATLAB Version: 9.8.0.1873465 (R2020a) Update 8 and libSBML 5.19.0. AMICI importSBML fails with error
Error using sym>convertChar (line 1546)
Character vectors and strings in the first argument can only specify a variable or number. To evaluate character
vectors and strings representing symbolic expressions, use 'str2sym'.

As a result, genSSI can no longer import SBML models.

This is related to AMICI issue AMICI-dev/AMICI#234, which was fixed 5 years ago. AMICI-dev/AMICI#234
It is also related (and documented) in the new libSBML issue 274. sbmlteam/libsbml#274

This can be reproduced by running genSSI runExample('BIOMD0000000003').

A straightforward fix to this is described in sbmlteam/libsbml#274.

@thomassligon
Copy link
Collaborator Author

In GenSSI, analysing the two models BIOMD0000000003 and MIOMD0000000010 now works in MATLAB R2020a after changing 3 lines in SBMLimporter/@SBMLode/importSBML.m.
How can we make sure that this is tested where necessary?

@FFroehlich
Copy link

Hi Tom, you can simply make a pull request here. We don't have any tests specifically for the importer as we used to test this directly in AMICI. Unfortunately, I don't think this will fix issues in amici since https://github.com/AMICI-dev/AMICI/blob/57a7b11cc2fb301cf838daefd966830c522643a8/matlab/%40optsym/optsym.m also broke with the R2018a update.

thomassligon added a commit that referenced this issue Oct 31, 2022
Changes for Issue #2 in importSBML
@thomassligon thomassligon mentioned this issue Oct 31, 2022
@thomassligon
Copy link
Collaborator Author

I created a pull request called Issue #2.

@thomassligon
Copy link
Collaborator Author

Hello Fabian, I see that you approved the pull request. What is the next step, and who needs to take it?

FFroehlich pushed a commit that referenced this issue Nov 2, 2022
Changes for Issue #2 in importSBML
@thomassligon
Copy link
Collaborator Author

That fixes the problem in importSBML detected while testing genssi-developer/GenSSI#19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants