-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for QueryRequestOption property ResponseContinuationTokenLimitInKb #432
Comments
Hi there @victormarante - I like this proposal. Would you be interested in helping out, by providing a PR? I'm imagining that we could add an overload that exposes this to the various APIs where it's needed. |
Hi! I can surely do so. I will look into your contribution guidelines and create a PR once I am done. |
Noticed you don't have a contribution guideline, but I will do my best. A question on what direction you are thinking:
Not sure which approach you fancy, but the easier on (point 1), might be what I begin with and we'll go from there. |
Yeah, I think the overload approach is the most straightforward (option 1). That seems similar to option 2, no? Wouldn't the overload accept a |
@all-contributors please add @victormarante for issue and code |
I've put up a pull request to add @victormarante! 🎉 |
Is your feature request related to a problem? Please describe.
Continuation tokens from Cosmos V3 SDK sometimes become too large for servers/browser agents too handle (either resulting in errors when receiving such a large item, or getting 414 URI too long). This issue happens when continuation token is part of route, but will also be an issue since it can be too large even for headers.
Describe the solution you'd like
QueryRequestOptions from the Cosmos SDK supports setting a continuation token limit. This would be helpful if it was exposed from this NuGet so we can control the size of the token in cases there it becomes to large
The text was updated successfully, but these errors were encountered: