Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove article page hero background color #87

Closed
joshdarby opened this issue Jan 23, 2020 · 3 comments
Closed

Remove article page hero background color #87

joshdarby opened this issue Jan 23, 2020 · 3 comments
Assignees
Labels
Estimate: 2h < 2 Hours
Milestone

Comments

@joshdarby
Copy link

Posts with no featured image are showing a gray box because of

.hero {
    text-align: center;
    background-color: #efefef;
    margin: 0 0 24px;
}

Let's remove that background color attribute.

Example:
Screen Shot 2020-01-23 at 12 36 12 PM

@joshdarby joshdarby added the Estimate: 2h < 2 Hours label Jan 23, 2020
@joshdarby joshdarby added this to the Post-launch milestone Jan 23, 2020
@joshdarby joshdarby self-assigned this Jan 23, 2020
@joshdarby
Copy link
Author

On second thought, this seems like a Largo issue with featured media.

Steps to reproduce:

  1. Add a featured media image
  2. Remove featured media from the post by going Featured Image -> Remove featured image
  3. View the frontend and note the gray box

@joshdarby
Copy link
Author

So, in the meantime, any post CIJN is experiencing this issue with can be fixed by selecting Featured Media -> Hide on Single Post display which will hide the hero element from the article page

@joshdarby
Copy link
Author

Largo issue: WPBuddy/largo#1845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: 2h < 2 Hours
Projects
None yet
Development

No branches or pull requests

2 participants