Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Error Handling / Instance changes #347

Open
awilliamson opened this issue Aug 29, 2015 · 0 comments
Open

Refactor Error Handling / Instance changes #347

awilliamson opened this issue Aug 29, 2015 · 0 comments

Comments

@awilliamson
Copy link
Member

Whilst doing other work I looked through the existing code for error handling. The interactions between entities, instance, and the SF Core is messy to put it lightly.

A refactoring would improve the ability to trace these errors, and improve tracebacks. Some Entity methods mimic Instance functions in their entirety with no real reason or added benefit.

I feel that Core, Instance, and Entity are far too tightly coupled/intertwined. This would be an ideal opportunity to do the Instance changes we've been planning. Make the Core focus on the Instance, with the Entity being a physical 'shell' for the SF Code. Have a clear categorisation of errors in zones, for the core, instance errors ( libs etc ), and SF code space all to be handled in a single easy-to-access location.

At the moment we have multiple pathways for erroring out, and multiple versions of functions which essentially do the same erroring task. Some cleanup after themselves, some are just warnings, over-time this haphazard erroring style has lead to superfluous calls and messy interaction and chaining; this needs to be cleaned up. Strict zoning and procedure should improve how contributors create code with error handling, and make for a better model for people wishing to understand how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant