Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review virtual machine class #449

Open
MatthewJohn opened this issue Jun 26, 2019 · 0 comments
Open

Review virtual machine class #449

MatthewJohn opened this issue Jun 26, 2019 · 0 comments
Milestone
Release 11.0.0

Comments

@MatthewJohn
Copy link
Collaborator

This is one of (if not the only class) that hasn't been refactored since the initial migration to pyro. It is worth checking some of the methods that are being used for remote code execution and permission checking. Worth checking for code duplication etc.
@MatthewJohn MatthewJohn added this to the Release 11.0.0 milestone Jun 26, 2019
MatthewJohn added a commit that referenced this issue Sep 8, 2019
@MatthewJohn
Fix use of camel-case in function names in VirtualMachine class and e…
eb594c7 
…xception syntax

Issue #449
MatthewJohn added a commit that referenced this issue Sep 17, 2019
@MatthewJohn
Remove membaloon state from get_info output for VM, since this has be…
092157c 
…en removed.

Issue #449
MatthewJohn added a commit that referenced this issue Sep 17, 2019
@MatthewJohn
Remove use of remove function get_memballoon_state in set_memballoon_…
f367866 
…deflation_state

Issue #449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 11.0.0
Development

No branches or pull requests
1 participant
@MatthewJohn