Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton updates #8

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Skeleton updates #8

merged 5 commits into from
Dec 10, 2024

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Dec 10, 2024

This PR brings the package up to date with the skeleton v0.2.0.

Note that there is a rather large amount of ambiguities related to wrapping number types like this, which I did not yet solve here.
A somewhat hidden statistic that might also be relevant to check is the number of invalidations, since this is typically a source of high latency, and often appears when defining new number types like this.

Copy link

codecov bot commented Dec 10, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@mtfishman
Copy link
Member

Note that there is a rather large amount of ambiguities related to wrapping number types like this, which I did not yet solve here. A somewhat hidden statistic that might also be relevant to check is the number of invalidations, since this is typically a source of high latency, and often appears when defining new number types like this.

Hmm yeah that is unfortunate, we don't want to introduce a bunch of ambiguities and invalidations since this is used by a lot of the new packages. Definitely would be good to look into that and see if there is a better way to design this package or achieve something similar with a different approach.

Looks like one of the test files needs formatting.

@mtfishman mtfishman merged commit 2940bd7 into ITensor:main Dec 10, 2024
11 checks passed
@lkdvos lkdvos deleted the skeleton branch December 10, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants