Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Destination in Response #770

Open
peppelinux opened this issue Jan 24, 2021 · 1 comment · May be fixed by #812
Open

Missing Destination in Response #770

peppelinux opened this issue Jan 24, 2021 · 1 comment · May be fixed by #812
Labels
bug

Comments

@peppelinux
Copy link
Member

peppelinux commented Jan 24, 2021 •
edited
Loading

a PySAML2 SP seems to accept a SAML Response with a missing Destination attribute, like the following

<samlp:Response ID="_4768c2f4-a8f2-4666-b40f-59173e6149e5" InResponseTo="id-Id3opS53KGqQDLuJI" IssueInstant="2021-01-24T02:12:03Z" Version="2.0" xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion" xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol">
@peppelinux peppelinux added the bug label Jan 24, 2021
peppelinux added a commit to peppelinux/pysaml2 that referenced this issue Mar 20, 2021
@peppelinux
fix: Destination missing or unvalued. Fixes: IdentityPython#770
18fbd74
peppelinux added a commit to peppelinux/pysaml2 that referenced this issue Mar 20, 2021
@peppelinux
fix: Destination missing or unvalued. Fixes: IdentityPython#770
a50db00
@peppelinux peppelinux mentioned this issue Mar 20, 2021
Closed
6 tasks
@peppelinux peppelinux reopened this Jun 14, 2021
@peppelinux
Copy link
Member Author

If binding is HTTP-POST or REDIRECT Destination MUST be present and validated

@c00kiemon5ter c00kiemon5ter linked a pull request Jul 27, 2021 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@c00kiemon5ter @peppelinux