Add: Ability to merge firstname and lastname when fullname is not the… #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re in ldap and add firstname and lastname in testcase
…ill merge and use as display name
munir131
reviewed
Oct 15, 2024
app/Access/LdapService.php
Outdated
| @@ -82,17 +82,24 @@ public function getUserDetails(string $userName): ?array | |||
| $idAttr = $this->config['id_attribute']; | |||
| $emailAttr = $this->config['email_attribute']; | |||
| $displayNameAttr = $this->config['display_name_attribute']; | |||
| $firstName = explode(',', $displayNameAttr)[0]; | |||
| $lastName = explode(',', $displayNameAttr)[0]; | |||
There was a problem hiding this comment.
@brijm-improwised it should be 1. Also, you should check length before accessing index 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Fixes Issue : LDAP_DISPLAY_NAME_ATTRIBUTE merge multiple values
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers