Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Attachment search functionality by content type in search #30

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Add Attachment search functionality by content type in search #30

wants to merge 2 commits into from

Conversation

brijm-improwised
Copy link
Collaborator

Fixes Issue : [Feature Request] Add "attachments" search filter.

closes #26

Changes proposed

  • Add Attachment in search filter in content type search
  • Also assign Entity model to Attachment model so that Attachment is also searchable
  • Add Test Case for attachment search
  • Fix Existing search test cases which is not pass due to changes
  • Add "owned_by" column in attachments table to associate each attachment with the owner of its related page

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@brijm-improwised
Add Attachment search functionality by content type in search, assign…
6e37e4b 
… Entity to Attachment model for improved searchability, and add an "owned_by" column to the attachments table to assign page owners to related attachments. Also fix existing test cases for searching and add search attachment test case.
@brijm-improwised brijm-improwised self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapanbavaliya tapanbavaliya Awaiting requested review from tapanbavaliya

@munir131 munir131 Awaiting requested review from munir131

Assignees

@brijm-improwised brijm-improwised

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add "attachments" search filter.
1 participant
@brijm-improwised