Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement additional API endpoints #4

Open
12 of 36 tasks
InputUsername opened this issue Aug 30, 2021 · 13 comments
Open
12 of 36 tasks

Implement additional API endpoints #4

InputUsername opened this issue Aug 30, 2021 · 13 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@InputUsername
Copy link
Owner

InputUsername commented Aug 30, 2021

A large number of new endpoints have been added to the ListenBrainz API since the release of listenbrainz-rs v0.3.0:

Core API Endpoints

Playlists API Endpoints

Feedback API Endpoints

Recording Recommendation API Endpoints

Recording Recommendation Feedback API Endpoints

User Timeline API Endpoints

Social API Endpoints

Pinned Recording API Endpoints

Stats API Endpoints

@shymega
Copy link
Collaborator

shymega commented Aug 30, 2021

Alright, good list - time to get crackin! Targeting to for v0.4.0, right?

@InputUsername
Copy link
Owner Author

Sure, although #2 and #3 are of higher priority (in my opinion).

@shymega shymega added enhancement New feature or request help wanted Extra attention is needed labels Aug 30, 2021
@InputUsername InputUsername added this to the v0.4.0 milestone Aug 30, 2021
@shymega
Copy link
Collaborator

shymega commented Aug 31, 2021

#2 closed now, #3 next priority. I'd say that #3 is a blocker for this issue.

@InputUsername
Copy link
Owner Author

#2 closed now, #4 next priority. I'd say that #4 is a blocker for this issue.

Do you mean #3? Working on that right now, it might take a while because attohttpc doesn't match ureq's API/behavior completely

@shymega
Copy link
Collaborator

shymega commented Aug 31, 2021

Oh, derp yeah - #3. GitHub selected the wrong one with the menu...edited.

@InputUsername
Copy link
Owner Author

I've started implementing a few endpoints on the feature/new-endpoints branch - the "core" endpoints are done.

ListenBrainz and MusicBrainz use the JSPF format to represent playlists (specifically, their own variant which has some extensions), which I've implemented in the raw::jspf module, so we can use those types for the other playlist endpoints as well.

@InputUsername
Copy link
Owner Author

Pushing this back to a future version so v0.4.0 can be included in the next release of rescrobbled.

@InputUsername InputUsername removed this from the v0.4.0 milestone Oct 20, 2021
@Kernald
Copy link
Contributor

Kernald commented Feb 5, 2024

I believe GET /1/playlist/(playlist_mbid) is missing from that list - simple download of a playlist through its mbid.

@Kernald
Copy link
Contributor

Kernald commented Feb 26, 2024

#19 is adding the endpoint I mentioned above - with that said, I'm curious about the status of this issue, as #19 builds upon a fairly old branch.

@RustyNova016
Copy link
Contributor

There is also GET /1/stats/release-group/(release_group_mbid)/listeners missing.

I have already started implementing it in my own branch, but I didn't see I needed to be on feature/new-endpoints so should I move it there or just do the pull request like that?

I'm also waiting on confirmation for the JSON format, so it's not 100% ready yet

@InputUsername
Copy link
Owner Author

@RustyNova016 feature/new-endpoints is really old at the moment but we're going to rebase it to main, so you should be able to create a PR from your own branch against that branch whenever you are ready 😄

@RustyNova016
Copy link
Contributor

I'm going to make a it a draft so it can be reviewed, apart from the schema that may need some Option<>s.
Sadly, other libraries didn't bother implementing it either, so I can't copy from there

@shymega
Copy link
Collaborator

shymega commented Mar 4, 2024

No objection for a draft from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants