Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Architecture and Dapr Application Templates use IdentityModel.AspNetCore nuget package #124

Open
stephanjohnson opened this issue Dec 20, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@stephanjohnson
Copy link

What happened?

When creating a new Clean Architecture or Dapr project and select Api Authorisation as the security option, the resulting Infrastructure project references IdentityModel.AspNetCore which is:

  1. Obsolete - This package has been deprecated as it is legacy and no longer maintained. more info
  2. Does not seem to be required, when I remove it from the Infrastructure project, the code still compiles

What version of Intent Architect are you using?

4.4.0-beta-1

Additional information

No response

@stephanjohnson stephanjohnson added the bug Something isn't working label Dec 20, 2024
@JonathanLydall
Copy link
Member

Thank you @stephanjohnson, we've logged this on our side to look at as soon as possible.

@stephanjohnson
Copy link
Author

I also noticed that there are some references to Microsoft.AspNetCore in the using clauses for the Intent.Infrastructure.DependencyInjection.DependencyInjection and Intent.Dapr.AspNetCore.ServiceInvocation.HttpClientHeaderHandlerTemplate, along with a reference to IHttpContextAccessor in the latter template.

This is resolved (for .net 9) by adding the following to the csproj file

<ItemGroup>
  <FrameworkReference Include="Microsoft.AspNetCore.App" />
</ItemGroup>

for previous versions of .net, the relevant http abstractions package references can be used.

@stephanjohnson
Copy link
Author

Another unused package in the Infrastructure project is the Newtonsoft.Json package. Specifically, if I use the IEvangelist.Azure.CosmosRepository and not the EF module, there is no need for this package, and it can be safely removed.

@joelsteventurner
Copy link
Member

@stephanjohnson noted, I have updated our ticket accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants