Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curse of the Bronze Tablet - "Skip Failed Cards" doesn't help #14

Closed
HelixVita opened this issue Jul 10, 2022 · 1 comment
Closed

Curse of the Bronze Tablet - "Skip Failed Cards" doesn't help #14

HelixVita opened this issue Jul 10, 2022 · 1 comment

Comments

@HelixVita
Copy link
Contributor

HelixVita commented Jul 10, 2022

Describe the bug
Certain cards, such as [[Bronze Tablet]], cause MTG-Proxyshop to fail to render in such a way that all subsequent cards also fail to render.

To Reproduce
Steps to reproduce the behavior:
Simply attempt to render one of the problem cards. The ones I've found so far are:

  • Bronze Tablet (Tom Wänerstrand) [ATQ]
  • Giant Oyster (Nicola Leonard) [HML]
  • Cooperation (Phil Foglio) [ICE]

If you do "Render Target" it will simply fail.

If you do "Render All" (on some arbitrary collection of art files which includes one of these problem cards), then those cards will render fine until Proxyshop reaches the problem card. It'll fail the same way, but then it will also proceed fail on every subsequent card. I.e. the "Skip Failed Cards" option does not protect against this kind of failure.

Additional observations:

  • Both Photoshop AND the Proxyshop GUI must be closed and re-started, else all cards will continue failing (even the non-problem cards).
  • Photoshop cannot be closed normally. Must end task using Task Manager.
  • Task manager reveals Photoshop is using a large amount of memory
  • Error in python terminal output says something about zero division error

Your system:
Note: I first encountered this using my "Ancient" template on my forked version of Proxyshop, so to be sure it wasn't just an issue with my setup I went ahead and reproduced the issue using a clean version of Proxyshop in a brand new virtual python env.

  • Proxyshop Template: "Normal"
  • Proxyshop version: Freshly cloned from main branch: bebd79e
  • Python version: 3.9 (Fresh virtual python environment with only the packages from requirements.txt)
  • Windows version: Windows 11
  • Photoshop version: 2022 latest

Screenshots
This gif was captured when I first encountered the problem:

BronzeTabletIsCursed

@Investigamer
Copy link
Owner

Problem definitely caused by #9 as we sussed out on Discord, most likely fixed in next release but will add these cards to the list in the tracker for issue 9. Case closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants