Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - The ability to render dev/test cards by supplying a cards.txt (instead of image files in art folder) #45

Open
HelixVita opened this issue Nov 6, 2022 · 0 comments
Assignees
Labels
feature request Request a new feature

Comments

@HelixVita
Copy link
Contributor

HelixVita commented Nov 6, 2022

Is your feature request related to a problem? Please describe.
The way I’m testing cards now is by just copy-pasting the exact same test picture, say, 100 times and giving it different names for the cards that I want to test. This is a bit tedious, and it increases the time it takes to develop and test new Proxyshop templates / plugins.

Describe the solution you'd like
I figure at this point it’d make more sense if it was possible to just feed Proxyshop a single txt file (essentially the same kind of "cards.txt" file that MTG-Art-Downloader uses). This would be a lot more simple than having to create 100 identical JPGs with different filenames.

To clarify. I’m not asking for a feature that automatically grabs the correct art from some repo. About 99% of the time I spend with Proxyshop is spent just testing and developing templates, so I don’t care about the art. Thus, as far as I'm concerned, they can all use the exact same sample image, for example the pumpkin patch one used in the test module.

As a bonus, I think having this kind of ability to run a render_all on a simple cards.txt file would make stuff like test-driven development and unit tests much easier. Not only for template creators, but for Proxyshop as a whole.

Just an idea, anyway.

Describe alternatives you've considered
Perhaps it's possible to get this functionality in Proxyshop by just expanding a bit on the functionality of the recently implemented "Dev Mode"? Aside from a few details, it seems pretty close to what I'm describing.

@HelixVita HelixVita added the feature request Request a new feature label Nov 6, 2022
@HelixVita HelixVita changed the title [FEATURE] - The ability to render dev/test cards by supplying a cards.txt (instead of an image file) [FEATURE] - The ability to render dev/test cards by supplying a cards.txt (instead of image files in art folder) Nov 6, 2022
@Investigamer Investigamer changed the title [FEATURE] - The ability to render dev/test cards by supplying a cards.txt (instead of image files in art folder) [FEAT] - The ability to render dev/test cards by supplying a cards.txt (instead of image files in art folder) Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a new feature
Projects
None yet
Development

No branches or pull requests

2 participants