You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using the "Default Expansion Symbol" (my current use case also has "Force Default Expansion Symbol" enabled), a set code used by Keyrune that doesn't have a direct folder name in mtg-vectors will fallback to the original "DEFAULT" (the circle M) symbol instead of translating to the correct symbol.
To Reproduce
Prepare an art file for a render.
In global settings, enable "Force Default Expansion Symbol", and set "Default Expansion Symbol" to "PMEI".
Render the target.
Expected: The card to render with the "STAR" symbol (mtg-vectors's manifest.json routes "PMEI" to "STAR").
Actual behavior: The card renders with the "DEFAULT" symbol.
Additional Information
It seems the set codes route correctly when used in the set field in the "Custom Creator". As well, using a routed set in the art filename behaves correctly.
Your system:
Proxyshop or Python version: v1.13.2
Windows version: 22H2 19045.4046
Photoshop version: v25.4.0
The text was updated successfully, but these errors were encountered:
Btw we no longer use keyrune just SVG symbols so that font is no longer required for the app just fyi if you care about not having extra fonts installed 👍 We should probably deprecate the text in the GUI that mentions a "keyrune" code.
As to the issue, at the time my thinking was if someone is going to force the symbol manually they can just reference the folder code (more typically the set code, since something like 95% of symbol codes are the same as the set code or parent set code outside the labyrinth that is random promo sets). Alternatively, I could use the manifest mapping primarily and use the folder name as a fallback? I don't think there would be any conflicting overlaps off the top of my head, but I can't be totally certain 😳
Btw we no longer use keyrune just SVG symbols so that font is no longer required for the app just fyi if you care about not having extra fonts installed 👍 We should probably deprecate the text in the GUI that mentions a "keyrune" code.
Interesting! I had sorta assumed as much when you started maintaining your own collection of symbols! (Which made it a bit more confusing to me when the custom creator seemed to route the set codes while the override didn't, haha)
As to the issue, at the time my thinking was if someone is going to force the symbol manually they can just reference the folder code (more typically the set code, since something like 95% of symbol codes are the same as the set code or parent set code outside the labyrinth that is random promo sets).
Honestly, this works fine for me. Sure applying the manifest mapping and then folders as a fallback would be "nice", but I don't think it's wildly important given my guess at how many people would actually use the feature. My only other thoughts were to like the ones in .extras or .alt.
Investigamer
changed the title
[BUG] - Default Expansion Symbol not correctly translated by keyrune set code
[FEAT] - Allow folder mapping for SVG symbols as a fallback for manifest mapping
Mar 28, 2024
When using the "Default Expansion Symbol" (my current use case also has "Force Default Expansion Symbol" enabled), a set code used by Keyrune that doesn't have a direct folder name in
mtg-vectors
will fallback to the original "DEFAULT" (the circle M) symbol instead of translating to the correct symbol.To Reproduce
Expected: The card to render with the "STAR" symbol (
mtg-vectors
'smanifest.json
routes "PMEI" to "STAR").Actual behavior: The card renders with the "DEFAULT" symbol.
Additional Information
It seems the set codes route correctly when used in the set field in the "Custom Creator". As well, using a routed set in the art filename behaves correctly.
Your system:
v1.13.2
19045.4046
v25.4.0
The text was updated successfully, but these errors were encountered: