Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Art File Naming: Render Overwrites #89

Open
RaphaelDDL opened this issue May 30, 2024 · 1 comment
Open

[FEATURE] - Art File Naming: Render Overwrites #89

RaphaelDDL opened this issue May 30, 2024 · 1 comment
Labels
feature request Request a new feature

Comments

@RaphaelDDL
Copy link

RaphaelDDL commented May 30, 2024

Describe the solution you'd like

I'd like that, when I render a card, I have the option to overwrite some settings from the card I am basing it, e.g.:

Mithril Coat[LTR](Saint Seiya)$RaphaelDDL.jpg

That breaks down to:

  • Mithril Coat card;
  • 'LTR' set (specifically in this case, could've been omitted since only exists in LTR)
  • Artist 'Saint Seiya'
  • creator 'RaphaelDDL'

I'd like to make my created card be found by the Scryfall API (and thus I provided real settings) while also being more personalized, with the set icon, rarity and nickname (in case using the nicknamed template version) I'd prefer for more flavor/uniqueness.

Describe alternatives you've considered

Following the Art File Naming convention ( https://github.com/Investigamer/Proxyshop?tab=readme-ov-file#-art-file-naming ), I thought of implementing the following modifiers:

Set

Improving the [SET] to accept a separator, where you could add the set to query (if needed) but also add the set you'd like to overwrite with after a symbol, for example, with !. So that [LTR!SLD] is card query to be LTR - so that, if I am using the "Import Scryfall Scan", it does follow the image/set I'm querying for, while also indicating the set icon that the rendered card will be using (SLD's shooting star set icon in this example).

If set was not provided/not needed for the api query to work, you can directly [!SLD] to only indicate the rendered set icon wanted.

Rarity

Adding %X to the filename, where X is the rarity:

  • C common
  • U uncommon
  • R rare
  • M mythical

and so on, thus using the appropriate set icon+rarity color

Nickname

When creating nicknamed cards, e.g., Borderless template "Use nickname" under text option, enable the possibility of adding directly through the filename. Or auto detect that this option was used and pick the "use nickname" for that specific render only. That would probably need a template update as well ofc.

Example, with symbol ~. So, when used, It would fill out the nickname above the real card name. "Scytheclaw Raptor~Tyrannosaurus Zord" and the both card name and nickname would be filled accordingly.

Additional context

So, to sum up, a card filename would become long but very customizable from the get go. Here a full art naming example:

Scytheclaw Raptor[LCI!SLD](Mighty Morphin Power Rangers)%M~Tyrannosaurus Zord$RaphaelDDL.jpg

Aka

  • Scytheclaw Raptor
  • from Lost Cavern of Ixalan
  • using SLD's shooting star set icon
  • artist 'Mighty Morphin Power Rangers'
  • Mythical (orange set icon)
  • nicknamed to 'Tyrannosaurus Zord'
  • creator 'RaphaelDDL'

And if I created another file equal, but without the ~Tyrannosaurus Zord, it would use regular borderless named "Scytheclaw Raptor", without the nickname template.

--

The symbols used are suggestions and are accepted by Windows in filenames. I'm open to discuss any of the ideas if you'd like!
I am not super good in Python but I should be able to work on this and submit a Pull Request, if you agree with all the feature suggestions. Please let me know.

Thank you for the awesome tool.

Best.

@RaphaelDDL RaphaelDDL added the feature request Request a new feature label May 30, 2024
@Investigamer
Copy link
Owner

Forcing symbol (and rarity) in filename and setting nickname in filename are both planned features via #90 and #91, among other improvements with turning the [] tag into a general config tag. v1.14 will be dropping soon and should include most of these improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a new feature
Projects
None yet
Development

No branches or pull requests

2 participants