Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[FEATURE] Amoled friendly Dark mode #3518

Closed
3 tasks done
MehrabShawon opened this issue Sep 15, 2024 · 5 comments
Closed
3 tasks done

[FEATURE] Amoled friendly Dark mode #3518

MehrabShawon opened this issue Sep 15, 2024 · 5 comments
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user

Comments

@MehrabShawon
Copy link

Please confirm the following:

  • I've checked the current issues for duplicate issues.
  • I've requested a single (only one) feature/change in this issue. It complies with the One Request Per GitHub Issue (ORPGI) rule.
  • My issue is well-defined and describes how it should be implemented from UI/UX perspective.

What do you want to be added or improved?

As a user I want to request an AMOLED-friendly dark mode. The current dark mode isn't pitch black, and it's uncomfortable for my eyes since I've been using a pitch-black theme for years. It would be great if you could add an AMOLED-friendly dark mode that features a true pitch-black background.

Why do you need it?

  • Comfortable for the eyes for some people (including me).
  • Looks better, in my opinion.
  • Consumes slightly less battery on phones with OLED/AMOLED displays.

How do you imagine it?

I'm looking for an AMOLED dark mode where the background is pitch black instead of gray.

@MehrabShawon MehrabShawon added the user request Feature/improvement requested by an user label Sep 15, 2024
@ivywallet
Copy link
Collaborator

Thank you @MehrabShawon for raising Issue #3518! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@ILIYANGERMANOV ILIYANGERMANOV added the approved Approved by the Ivy Wallet team. Ready for dev label Sep 15, 2024
@paulolima18
Copy link
Contributor

Changing the default black in the object IvyColors from this val Black = Color(0xFF09090A) to this val Black = Color(0xFF000000) is enought I think, does this work or maybe we should create a new Theme? @ILIYANGERMANOV

@ILIYANGERMANOV
Copy link
Collaborator

We should create a new theme. Otherwise, we'll break our original dark mode that most users like

@paulolima18
Copy link
Contributor

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @paulolima18! 🎉
Issue #3518 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user
Projects
None yet
Development

No branches or pull requests

4 participants