[Feature] Hide Selected Accounts In Accounts Tab

[shamim-emon]

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

• I've read the Contribution Guidelines and my PR doesn't break the rules.
• I've read and understand the Developer Guidelines.
• I confirm that I've run the code locally and everything works as expected.
• My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
• 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

demo.mp4

What's changed?

Describe with a few bullets what's new:

• I've added hide accounts functionality for Accounts tab

Risk factors

What may go wrong if we merge your PR?

• N/A

In what cases won't your code work?

• N/A

Does this PR close any GitHub issues? (do not delete)

• Closes [FEATURE] Hide selected accounts from the Accounts screen #3497

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

[nvllz]

Thank you for taking my request! It looks good, but I'd also think about some background dim/linear pattern or other way to distinguish hidden accounts on the list.

[shinebrillant]

Hello, I think this is redundant. Can the sorting and hiding functions be merged?
Can click the sort icon above to decide how to sort and hide multiple accounts?

[shamim-emon]

Thank you for taking my request! It looks good, but I'd also think about some background dim/linear pattern or other way to distinguish hidden accounts on the list.

@nvllz please have a look at the updated video

[shamim-emon]

Hello, I think this is redundant. Can the sorting and hiding functions be merged? Can click the sort icon above to decide how to sort and hide multiple accounts?

@shinebrillant I'd prefer to keep sorting & hiding separate as merging them might make the UI complex. Let wait for @ILIYANGERMANOV's comment on this.

[nvllz]

@shamim-emon Much better, thanks! Could be a bit more opaque, but it's definitely easier to spot hidden accounts now.

[nvllz]

I'd prefer to keep sorting & hiding separate as merging them might make the UI complex.

Your UI fits better other areas of the app, you could think of implementing the ordering on your screen under the icon of a gear. I don't think it would be too complex, users could order and hide these cards in one place. Additionally if there was a way to make the hidden entries not affect the visibility icon (it's also getting dimmed), it would look more professional.

Thanks for your work, Shamim.

[ILIYANGERMANOV]

Thank you for your contribution to the Ivy Wallet project. We appreciate the time and effort you've invested in this pull request.

As of Nov 5th, 2024, Ivy Wallet is no longer maintained. We are closing all open pull requests as part of the project shutdown.

While we won't be merging this pull request, you're welcome to fork the repository and continue development independently under the terms of the GPL-3.0 License.

For more information, please refer to the shutdown notice in our README file.

We apologize for any inconvenience and thank you again for your interest in improving Ivy Wallet.