Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post-RIIC++] Implement linter #47

Open
JCWasmx86 opened this issue Feb 24, 2024 · 6 comments
Open

[Post-RIIC++] Implement linter #47

JCWasmx86 opened this issue Feb 24, 2024 · 6 comments

Comments

@JCWasmx86
Copy link
Owner

mesonlsp will stay the same. A tool called mesonlint will be introduced that can be used as a full-blown linter. Features

  • Formatting with (statically linked) muon.
  • Use of a config file (.meson_lint?, maybe avoid using the meson prefix too much) for passing analysis/formatting options (E.g. to disable/enable checks or to set the severity)
  • CI Integration (See [Post-RIIC++] Integrate with Github Workflow commands #40)
@tristan957
Copy link
Collaborator

if we could get formatting and linting upstream into Meson, I think that would be best :)

@Freed-Wu
Copy link

I notice mesonlint in 4.1.8. 😄 It looks like documents are few. And a pre-commit-hooks is necessary.

@JCWasmx86
Copy link
Owner Author

It's currently not usable/finished and was only in the release due to more important things (Vulnerability fixes). If it's finished, feel free to provide required stuff for pre-commit hooks

@JCWasmx86
Copy link
Owner Author

There is now a linter in the main branch. It supports formatting with muon and just does the same as mesonlsp, just a bit fancier.

Current status:

  • Not all things from meson format are supported => Will add them to my muon fork and eventually upstream them: Conflict between muon fmt and meson format
  • Too many log messages
  • Not integrated with the language server
  • .mesonlint.toml as config file

Things I want:

  • Github Action Integration (Maybe even a Github Action just for linting, like e.g. Shellcheck)
  • More fixes
  • Integration with language server

@JCWasmx86
Copy link
Owner Author

The formatting options of meson format are now in muon, too thanks to the work of Annacrombie: muon-build/muon@58e3eaa

@JCWasmx86
Copy link
Owner Author

JCWasmx86 commented May 7, 2024

This is now implemented. If somebody wants pre-commit hooks, patches are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants