Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure that common folder files are published so types are not missing #351

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix: ensure that common folder files are published so types are not missing #351

merged 2 commits into from
Oct 16, 2024

Conversation

JamesLMilner
Copy link
Owner

Description of Changes

  • Ensures the common folders are published to npm, which I believe has been causing type failures relating to adapters/common.ts

Link to Issue

I think this partially resolves #350

PR Checklist

  • The PR title follows the conventional commit standard
  • There is a associated GitHub issue
  • If I have added significant code changes, there are relevant tests
  • If there are behaviour changes these are documented

@JamesLMilner JamesLMilner merged commit aa180dd into main Oct 16, 2024
6 checks passed
@JamesLMilner JamesLMilner mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Library not usable without skipLibCheck: true?
1 participant
@JamesLMilner