Allow variable assignment with @infiltry

[theogf]

This will allow for code like

@infiltry x = 3
2x

to work.

Otherwise, x will be only defined in the try scope.

[pfitzseb]

I don't think this is the correct fix because it makes x global, IIUC.
And, arguably, people should just write

x = @infiltry foo()
2x

instead.

[theogf]

Ah you're right, we could potentially manipulate the expression as

x = try
  ..
catch
 @infiltrate
end

if @infiltry x = f(..) is called?

[pfitzseb]

Yeah, but I still think that's not really worth it. Most* macros like this return their value, so x = @infiltry foo() should already be familiar.

*: Citation needed

[theogf]

Yeah, but I still think that's not really worth it. Most* macros like this return their value, so x = @infiltry foo() should already be familiar.

*: Citation needed

Yeah but what's unexpected is that the macro creates a new scope? I mentioned the new macro to someone and their first reaction was "oh I cannot assign variables using the macro" (unlike @show for example)

[theogf]

I went forward with my proposal. Also, I don't know if it was intentional but the exception was not rethrown

[pfitzseb]

Yeah, we definitely should rethrow here. I'm fine with this implementation, but it's not super generic -- ideally we'd somehow hoist all local assignments out of the new scope, but that's actually pretty tricky I think.

Also, can you please add a new test instead of modifying the old one?

[theogf]

ideally we'd somehow hoist all local assignments out of the new scope

So you mean in the case someone would do:

@infiltry begin
   x = 3
   y = 2x
end

Also, can you please add a new test instead of modifying the old one?

Yep, will rework the tests.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.61%. Comparing base (13f09b4) to head (278237c).

Files	Patch %	Lines
src/Infiltrator.jl	85.71%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   76.53%   76.61%   +0.07%     
==========================================
  Files           1        1              
  Lines         439      449      +10     
==========================================
+ Hits          336      344       +8     
- Misses        103      105       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pfitzseb]

Don't need the indentation here if you add the fence.

Would also be good to add the rethrows in both cases.

[pfitzseb]

Suggested change

	rethrow(ex)
	rethrow()

is more correct I think.