Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the direct dependency on libgit2 to an extension #165

Closed
wants to merge 1 commit into from

Conversation

ChrisRackauckas
Copy link

This is a breaking change, and thus updated to v1.0 with a note in the README on updating.

@fredrikekre
Copy link
Member

Since package installs are not repos anymore I wonder how useful this functionality is. It basically never works, right? I guess it works when you build your own docs in CI though.

@ChrisRackauckas
Copy link
Author

Yes, so it generally doesn't work except for CI building of docs, which is another reason to not require it downstream.

Also, the failures in CI here are also failures on master, so there's other unrelated maintenance issues in this package which hopefully won't block this change.

@nhz2
Copy link

nhz2 commented Aug 13, 2024

Please test that this change doesn't break packages' documentation. For example: https://ap6yc.github.io/AdaptiveResonance.jl/stable/man/full-index/#AdaptiveResonance.classify-Tuple{ARTModule,%20AbstractVector{T}%20where%20T%3C:Real}

And the many other uses of the METHODLIST https://juliahub.com/ui/Search?q=$(METHODLIST)&type=code

@ChrisRackauckas
Copy link
Author

How is that related? I only touched URL. MethodList is completely untouched and still passes its tests.

method lists                 |    3            3  1.3s

@nhz2
Copy link

nhz2 commented Aug 13, 2024

The url function is explicitly not part of the public API of this package so it can be removed without making a breaking change if there are no downstream problems.

@nhz2 nhz2 mentioned this pull request Aug 13, 2024
@nathanaelbosch
Copy link

According to SemVer pre-1.0 releases are allowed to be breaking, so there is no actual need to make a 1.0 release I think? Any compat entry for 0.9 would need to be manually updated to 0.10 anyways to opt in to this change. And the downside of the 1.0 release is that afterwards, changes like this actually need a new breaking release to a major version.

@KristofferC
Copy link
Member

Extensions ideally shouldn't be used like this because your code might all of a sudden break if a transitive dependency drop their libgit2 dependency.

@mortenpi
Copy link
Member

Let's close this -- I think #167 is the simpler approach here.

@mortenpi mortenpi closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants