Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions workflows for downstream testing #2314

Closed
3 tasks
mortenpi opened this issue Oct 29, 2023 · 2 comments · Fixed by #2323
Closed
3 tasks

GitHub Actions workflows for downstream testing #2314

mortenpi opened this issue Oct 29, 2023 · 2 comments · Fixed by #2323
Labels
good first issue Indicates a good issue for first-time contributors Type: Maintenance

Comments

@mortenpi
Copy link
Member

mortenpi commented Oct 29, 2023

The goal would be to set up standard CI workflow that we could use to downstream-test some packages and documentation builds. These would act as canaries for any breaking changes to internal we might be doing:

  • A couple of candidates for packages: DocumenterCitations, DocumenterMermaid (pick a commit, run the package's test suite, but with Documenter#master as dependency)
  • We could also try to build some documentations, but not sure who are good candidates. The ones that would be good canaries (like JuMP) are very expensive to build.
  • If we can, we could also try to build the Julia manual. Maybe we can just pull the tarball of the latest release? This is also a bit expensive, but possibly worth it.

For the more expensive downstream tests, we could add some concurrency options to avoid too many unnecessary builds.

It's a nice self-contained issue for anyone who wants to dabble with GitHub Actions.

@mortenpi mortenpi added Type: Maintenance good first issue Indicates a good issue for first-time contributors labels Oct 29, 2023
@odow
Copy link
Collaborator

odow commented Oct 29, 2023

JuMP (and MathOptInterface) have a set of workflow-dispatch tests that can be run on-demand:

We always run these before tagging each release, and we optionally run them on PRs of concern that may have downstream effects.

Here's a recent example where it was useful: jump-dev/MathOptInterface.jl#2318. The changes in that PR are not publicly breaking, but they add new features, and because of the opt-out nature of JuMP's testing system, it initially caused downstream solvers to start running (and failing) a new set of tests.

@mortenpi
Copy link
Member Author

workflow-dispatch is a great idea for the expensive builds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Indicates a good issue for first-time contributors Type: Maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants