Specialize common reductions for ranges with init
specified
#56896
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that since ranges have
O(1)
reductions such asminimum
,maximum
andsum
defined, we may reuse the implementations in the corresponding reductions withinit
specified, instead of hitting slow fallback implementations.for example, after this,
whereas, on master, this is
O(N)
as it loops over each element.The specific use case is to avoid hitting slow fallbacks in a change like https://github.com/JuliaLinearAlgebra/BlockBandedMatrices.jl/pull/218/files.