Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make structs immutable? #44

Open
jishnub opened this issue Mar 24, 2023 · 0 comments
Open

Make structs immutable? #44

jishnub opened this issue Mar 24, 2023 · 0 comments

Comments

@jishnub
Copy link
Member

jishnub commented Mar 24, 2023

Several structs in this package are mutable, but I don't see their fields being mutated, and changing some of these to immutable still gets tests to pass. I wonder if we can change some of these to immutable, and only retain mutability where it's absolutely necessary?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jishnub