-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update_on_release option to Slider #268
Add update_on_release option to Slider #268
Conversation
Thanks, works fine in simple cases! |
@aplavin Thanks, I hadn't noticed the |
You could also make a “debouncer” wrapping widget! (Search for “throttle vs debounce”) That would be really useful in a general way.
- fons
… Op 21 sep. 2023 om 07:31 heeft holomorphism ***@***.***> het volgende geschreven:
@aplavin Thanks, I hadn't noticed the combine() problem. I have fixed the points you mentioned.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
@fonsp Certainly the "debouncer" looks very useful for reactive programming in Pluto in general. |
Thanks @holomorphism and sorry for the late reply! What's still missing for #69 is proper support for AbstractPlutoDingetjes. Take a look at how Do you think we should still include this PR if we have a general |
Thanks for the reply, @fonsp! I will check the
I have been using Thank you very much! |
For those who stumble across this PR and want this feature: |
It looks like this could be implemented in a slightly more robust way by listening to the |
Add
update_on_release
option toSlider
. (Implement #267)If this option is set to
true
, slider value changes will not take effect until the mouse button is released.(The
confirm()
function is available for the similar purpose, but I thought it would be nice to have this option as well, since it is handy.)I have checked this to work in the following environment:
In order to support touch input, both "mouseup" and "touchend" events are watched by
addEventListener()
in the javascript code.(The "mouseup" and "touchend" events did not seem to occur at the same time.)