Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite to use Hyperscript.jl #59

Closed
fonsp opened this issue Oct 15, 2020 · 2 comments · Fixed by #148
Closed

Rewrite to use Hyperscript.jl #59

fonsp opened this issue Oct 15, 2020 · 2 comments · Fixed by #148

Comments

@fonsp
Copy link
Member

fonsp commented Oct 15, 2020

Because it makes this package more stable because we will never have HTML errors. The other option is to use a HTML parser in our testing to verify the output, but using Hyperscript is much nicer.

Also it's a nice package to work with!
@fonsp
Copy link
Member Author

fonsp commented Oct 15, 2020

You can do this work mostly inside a Pluto notebook, and copy things over to PlutoUI when you're done!

@pankgeorg pankgeorg mentioned this issue Oct 23, 2020
Closed
@SyxP SyxP mentioned this issue May 21, 2021
Closed
@fonsp
Copy link
Member Author

fonsp commented Dec 10, 2021

Done in #148

@fonsp fonsp closed this as completed Dec 10, 2021
@fonsp fonsp linked a pull request Dec 10, 2021 that will close this issue
🐣 Transforming values: AbstractPlutoDingetjes integration #148
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐣 Transforming values: AbstractPlutoDingetjes integration JuliaPluto/PlutoUI.jl
1 participant
@fonsp