-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: BusInjectionModel v0.1.0 #115285
New package: BusInjectionModel v0.1.0 #115285
Conversation
JuliaRegistrator
commented
Sep 16, 2024
•
edited
Loading
edited
- Registering package: BusInjectionModel
- Repository: https://github.com/NLaws/BusInjectionModel.jl
- Created by: @NLaws
- Version: v0.1.0
- Commit: 31344f1c66c868539cce6a5b33bd2d89a557d87f
- Reviewed by: @NLaws
- Reference: NLaws/BusInjectionModel.jl@31344f1#commitcomment-150683574
- Description: Various forms of the Bus Injection Model (power flow equations) built on the CommonOPF.jl package
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines are all met! ✅Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. 3. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
This package is currently empty and is thus not ready for registration yet. We do not allow for "placeholder" registration. If you are registering to make development workflows easier, please consider using a LocalRegistry |
309e972
to
9912ccd
Compare
9912ccd
to
94372b7
Compare
…01-10-51-093-00144106900 CompatHelper: add new compat entry for JuMP at version 1, (keep existing compat)
@goerz [noblock] I'm not sure what the issue is here: I think that the problem is ┌ Error: Was not able to successfully `Pkg.add` the package
└ @ RegistryCI.AutoMerge ~/.julia/packages/RegistryCI/mNCS2/src/AutoMerge/guidelines.jl:836
┌ Info: Version can be `Pkg.add`ed
│ meets_this_guideline = false
└ message = "I was not able to install the package (i.e. `Pkg.add(\"BusInjectionModel\")` failed). See the AutoMerge logs for details." But I also see: [ Info: IMPORTANT: If you see any messages of the form "Error: Some registries failed to update"or "registry dirty", please disregard those messages. Those messages are normal and do not indicate an error. and all the errors seem to be related to errors that the |
[noblock] I don't see anything very obvious. The logs to look at are in the "Checks" tab at the top of the page: https://github.com/JuliaRegistries/General/pull/115285/checks and specifically https://github.com/JuliaRegistries/General/actions/runs/11405524579/job/31737190398 The reported error is
Seems a bit odd, but that would be the thing to investigate. Other logs for the registration CI can be a bit misleading, and are generally for internal use only This is what
is trying to tell you. Those "errors" are not what is causing the failure. Usually, "I was not able to install/load the package" errors can be resolved by testing locally. In this case, I was able to clone and instantiate your package, so I (you) would have to look deeper. I did notice that trying to run your test suite fails:
You definitely want to make sure that you can run your tests locally and on CI before registering. Note that red CI badge in your README. Make sure that is green, and then see if you are still getting errors when trying to register. |
Oh, never mind, that's for the "pre" version of Julia. I recommend not routinely testing against pre-releases/nightlies of Julia as part of your regular CI. This will give you a lot of false positives. Instead, test against the oldest Julia version you support, and the current release. [noblock] |
I should add, though: in order to be registered, your package will also need some documentation (in addition to passing the automatic checks). At the very least, that would be a description of the package's purpose and a small usage example in the README |
Thank you @goerz all very helpful! I found an issue in the OpenDSSDirect dependency that was causing things to fail. I'll come back to this with more documentation. |
UUID: 20cea600-32a0-4edf-8dad-2de078d2a706 Repo: https://github.com/NLaws/BusInjectionModel.jl.git Tree: 5c10a035ca6792640eb1b6684da0c7966e6bae91 Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
94372b7
to
d665b65
Compare
This PR can be closed in favor of #122048 |