Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: BusInjectionModel v0.1.0 #115285

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Sep 16, 2024

Copy link
Contributor

github-actions bot commented Sep 16, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Sep 16, 2024

This package is currently empty and is thus not ready for registration yet. We do not allow for "placeholder" registration. If you are registering to make development workflows easier, please consider using a LocalRegistry

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-businjectionmodel-20cea600-v0.1.0-95e5eb375f branch from 309e972 to 9912ccd Compare September 17, 2024 14:20
@github-actions github-actions bot added the stale label Oct 18, 2024
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-businjectionmodel-20cea600-v0.1.0-95e5eb375f branch from 9912ccd to 94372b7 Compare October 18, 2024 14:23
JuliaRegistrator referenced this pull request in NLaws/BusInjectionModel.jl Oct 18, 2024
…01-10-51-093-00144106900

CompatHelper: add new compat entry for JuMP at version 1, (keep existing compat)
@NLaws
Copy link

NLaws commented Oct 18, 2024

@goerz [noblock] I'm not sure what the issue is here: I think that the problem is

┌ Error: Was not able to successfully `Pkg.add` the package
└ @ RegistryCI.AutoMerge ~/.julia/packages/RegistryCI/mNCS2/src/AutoMerge/guidelines.jl:836
┌ Info: Version can be `Pkg.add`ed
│   meets_this_guideline = false
└   message = "I was not able to install the package (i.e. `Pkg.add(\"BusInjectionModel\")` failed). See the AutoMerge logs for details."

But I also see:

[ Info: IMPORTANT: If you see any messages of the form "Error: Some registries failed to update"or "registry dirty", please disregard those messages. Those messages are normal and do not indicate an error.

and all the errors seem to be related to errors that the IMPORTANT message says to ignore.

@goerz
Copy link
Member

goerz commented Oct 18, 2024

[noblock]

I don't see anything very obvious.

The logs to look at are in the "Checks" tab at the top of the page: https://github.com/JuliaRegistries/General/pull/115285/checks and specifically https://github.com/JuliaRegistries/General/actions/runs/11405524579/job/31737190398

The reported error is

ERROR: Error building `OpenDSSDirect`: 
ERROR: LoadError: ArgumentError: Package Downloads does not have NetworkOptions in its dependencies:
- You may have a partially installed environment. Try `Pkg.instantiate()`
  to ensure all packages in the environment are installed.
- Or, if you have Downloads checked out for development and have
  added NetworkOptions as a dependency but haven't updated your primary
  environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with Downloads

Seems a bit odd, but that would be the thing to investigate.

Other logs for the registration CI can be a bit misleading, and are generally for internal use only

This is what

[ Info: IMPORTANT: If you see any messages of the form "Error: Some registries failed to update"or "registry dirty", please disregard those messages. Those messages are normal and do not indicate an error.

is trying to tell you. Those "errors" are not what is causing the failure.

Usually, "I was not able to install/load the package" errors can be resolved by testing locally. In this case, I was able to clone and instantiate your package, so I (you) would have to look deeper.

I did notice that trying to run your test suite fails:

  Got exception outside of a @test
  OpenDSSDirect.Utils.OpenDSSDirectException("[ERROR 243] Redirect file not found: \"data/ieee13/IEEE13Nodeckt_no_trfxs.dss\"")

You definitely want to make sure that you can run your tests locally and on CI before registering. Note that red CI badge in your README. Make sure that is green, and then see if you are still getting errors when trying to register.

@goerz
Copy link
Member

goerz commented Oct 18, 2024

Note that red CI badge in your README

Oh, never mind, that's for the "pre" version of Julia. I recommend not routinely testing against pre-releases/nightlies of Julia as part of your regular CI. This will give you a lot of false positives. Instead, test against the oldest Julia version you support, and the current release.

[noblock]

@goerz
Copy link
Member

goerz commented Oct 18, 2024

I should add, though: in order to be registered, your package will also need some documentation (in addition to passing the automatic checks). At the very least, that would be a description of the package's purpose and a small usage example in the README

@github-actions github-actions bot removed the stale label Oct 19, 2024
@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Oct 26, 2024
@NLaws
Copy link

NLaws commented Oct 27, 2024

Thank you @goerz all very helpful!

I found an issue in the OpenDSSDirect dependency that was causing things to fail. I'll come back to this with more documentation.

UUID: 20cea600-32a0-4edf-8dad-2de078d2a706
Repo: https://github.com/NLaws/BusInjectionModel.jl.git
Tree: 5c10a035ca6792640eb1b6684da0c7966e6bae91

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-businjectionmodel-20cea600-v0.1.0-95e5eb375f branch from 94372b7 to d665b65 Compare December 23, 2024 20:40
JuliaRegistrator referenced this pull request in NLaws/BusInjectionModel.jl Dec 23, 2024
@NLaws
Copy link

NLaws commented Dec 27, 2024

This PR can be closed in favor of #122048

@goerz goerz closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants