-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit compat bounds for the Distributed stdlib #121256
base: master
Are you sure you want to change the base?
Add explicit compat bounds for the Distributed stdlib #121256
Conversation
Would it be possible to have a PR that first normalizes all the whitespace in the registry (which would be easy to review) and then have this on top of it so that it wouldn't mix actual changes with whitespace only? |
I can make the PR but you'll have to merge it pretty quickly to avoid merge conflicts 😛 |
I thought there were tests that verify that files roundtrip after parsing and rewriting. Perhaps we are just testing that the parsed output is equal to the parsed-written-reparsed output? Is this a change in TOML.jl? |
Hm, the changes here seems to undo #65999.
JuliaRegistries/RegistryCI.jl#459 doesn't seem closed |
Is there like a preference for formatting that I'm missing or something? |
d607bd3
to
567b4be
Compare
Running the stdlib updater on 1.10 seems to have removed the whitespace changes, but now there's 500 modified files instead of 512 🤔 |
These are the packages that were skipped when running in 1.10: julia> setdiff(dot_11, dot_10)
12-element Vector{SubString{String}}:
"BLAKJac"
"ClimaCalibrate"
"CloudClusters"
"EwaldSummations"
"GeoStatsProcesses"
"LibraryAugmentedSymbolicRegression"
"OpenGeoSysUncertaintyQuantification"
"Oscar"
"ParametricProcesses"
"PulseInputDDM"
"TableTransforms"
"TopologicalNumbers" They all already have compat bounds and the difference between the diffs looks to be purely whitespace changes, e.g.: modified P/ParametricProcesses/Compat.toml
@@ -1,3 +1,3 @@
[0]
-Distributed = "1.9.2-1"
-julia = "1.5.0-1"
+Distributed = "1.9.2 - 1"
+julia = "1.5.0 - 1" So I think the new diff from 1.10 can be trusted. |
567b4be
to
3cf4618
Compare
I realized this didn't actually have a package directory for Distributed, added it in 3cf4618. Does anyone know how to test it? When I put the clone in Error: Some registries failed to update:
│ — `~/.julia/registries/General` — registry dirty
└ @ Pkg.Registry ~/.julia/juliaup/julia-1.11.2+0.x64.linux.gnu/share/julia/stdlib/v1.11/Pkg/src/Registry/Registry.jl:546 (this is with all changes committed) |
Unfortunately this also includes a bunch of extraneous whitespace changes. In total there are 512 affected packages.
I believe all the previous steps have already been done: JuliaLang/julia#50697
Requires this PR to reproduce: KristofferC/StdlibRegistryCompatUpdater#2
CC @vchuravy