Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBFGS should have its own meta #29

Open
abelsiqueira opened this issue Aug 5, 2021 · 2 comments
Open

LBFGS should have its own meta #29

abelsiqueira opened this issue Aug 5, 2021 · 2 comments

Comments

@abelsiqueira
Copy link
Member

For instance, nlp.meta.nnzh should be 0.

@dpo
Copy link
Member

dpo commented Feb 26, 2024

Actually, it’s more likely to be $n * (n+1) / 2$. I think it would be better to implement getters for meta instead of accessing fields directly.

@tmigot
Copy link
Member

tmigot commented Feb 26, 2024

Actually, such getters already exist https://jso.dev/NLPModels.jl/dev/reference/#NLPModels.get_nnzh-Tuple{NLSMeta} for instance, but are not really used (yet?) and are sometimes buggy, for instance JuliaSmoothOptimizers/NLPModels.jl#415 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants