Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly issue #36

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Fix nightly issue #36

merged 4 commits into from
Sep 25, 2023

Conversation

geoffroyleconte
Copy link
Member

Related to #35

@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/coo_linalg.jl 100.00%

📢 Thoughts on this report? Let us know!.

@dpo
Copy link
Member

dpo commented Sep 22, 2023

What was the issue with the strict option?

@geoffroyleconte
Copy link
Member Author

geoffroyleconte commented Sep 22, 2023 •
edited
Loading

What was the issue with the strict option?

See the breaking changes here:
https://github.com/JuliaDocs/Documenter.jl/blob/v1.0.1/CHANGELOG.md#breaking

@amontoison
Copy link
Member

Can you add a compat entry Documenter = "1.0" in the file docs/Project.toml?

@amontoison amontoison merged commit aa3694f into JuliaSmoothOptimizers:main Sep 25, 2023
10 of 11 checks passed
@amontoison
Copy link
Member

Thanks Geoffroy!

@geoffroyleconte geoffroyleconte deleted the fix-nightly branch September 25, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontoison amontoison amontoison approved these changes

@paraynaud paraynaud paraynaud approved these changes

@d-monnet d-monnet Awaiting requested review from d-monnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geoffroyleconte @dpo @amontoison @paraynaud