Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests in test_preprocessing.py #40

Open
atselikov opened this issue Oct 29, 2019 · 0 comments
Open

Improve tests in test_preprocessing.py #40

atselikov opened this issue Oct 29, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@atselikov
Copy link
Contributor

  1. Use 3 different DF for train/test/validation
dataframe_dict = {
    "train": train_dataframe,
    "valid": train_dataframe,
    "test": train_dataframe,
}
  1. Adopt test_valid_dataset and test_test_dataset for it
@atselikov atselikov added enhancement New feature or request good first issue Good for newcomers labels Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atselikov