Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter oscillogram example does not work after renaming of functions #12

Closed
JMulder99 opened this issue Nov 14, 2024 · 6 comments · Fixed by #13
Closed

Matter oscillogram example does not work after renaming of functions #12

JMulder99 opened this issue Nov 14, 2024 · 6 comments · Fixed by #13

Comments

@JMulder99
Copy link
Contributor

The example in examples/matter_oscillogram.jl does not work because some functions have been renamed in previous commits.

JMulder99 added a commit to JMulder99/Neurthino.jl that referenced this issue Nov 14, 2024
@JMulder99
Copy link
Contributor Author

I made it such that the example is also run as a test, but that means it needs to add Plots as a test dependency. This makes the compiling before testing quite a bit longer, but it ensures a working example.

@tamasgal
Copy link
Member

Ah, thanks Jelmer for taking care! I think it would be a good idea to include the example in the docs and add their Plots.jl as dependency (I'd rather prefer CairoMakie, but that's another topic 😆 )

@JMulder99
Copy link
Contributor Author

NP, Neurthino.jl is great little package. Do you mean we should include the example file as a separate page in the docs, and can we then show the output? You already have the step by step example in the README. The matter_oscillogram.jl example is not very different as I see it.

@JMulder99
Copy link
Contributor Author

In JMulder99:make_example_work, I removed the example entirely and replaced it with an new page in the docs. When making the docs, it runs the code directly and includes the plots in the html output.

@JMulder99
Copy link
Contributor Author

What should we do with the examples in the README?

Also, the use case of U_mat, H_mat = MatterOscillationMatrices(U, H, 1, 13); is a bit vague, because Pνν already converts them based on the paths you give.

@tamasgal
Copy link
Member

Can you make a pull request? We can discuss there :) i hope to get @8me involved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants