Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a preprocessor enable for provisional extensions or features #272

Open
bashbaug opened this issue Oct 19, 2023 · 0 comments
Open

add a preprocessor enable for provisional extensions or features #272

bashbaug opened this issue Oct 19, 2023 · 0 comments

Comments

@bashbaug
Copy link
Contributor

I've been generally trying to reduce the number of special CL_HPP_FOO preprocessor defines in these C++ headers, but I think it would be good to add a preprocessor define to explicitly opt-in to provisional extensions or features. This will avoid breaking code that doesn't use these features if their definitions change as part of the provisional review process, say by removing or renaming functions or enumerants.

Assuming we want to do this, the hardest thing will probably be deciding on a name. Some options:

  • CL_HPP_ENABLE_PROVISIONAL_FEATURES
  • CL_HPP_ENABLE_EXPERIMENTAL_FEATURES
  • CL_HPP_USE_PROVISIONAL_FEATURES

There are already several defines to ENABLE or USE features, such as CL_HPP_ENABLE_EXCEPTIONS and CL_HPP_USE_CL_SUB_GROUPS_KHR, so although I have a slight preference for ENABLE I think we could go either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant