Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options for the importer #391

Closed
luizcarlosfx opened this issue Apr 4, 2019 · 3 comments
Closed

Add more options for the importer #391

luizcarlosfx opened this issue Apr 4, 2019 · 3 comments

Comments

@luizcarlosfx
Copy link

luizcarlosfx commented Apr 4, 2019

The importer could have toggles to choose how to import some features:

  • Bones
  • Animations
  • Combine primitives
  • Materials
  • Textures

In my case I don't want to import animations, nor bones. I added those options myself, but it's not that good since I want to receive your future updates without trouble. Also, your GLTFSceneImporter could be splited by module like (MaterialImporter, MeshImporter, HierarchyImporter, TextureImporter, AnimationImporter) that way it would be easier to maintain the code, the class now has 2000+ lines of code.

Thanks for the good work, you're doing an amazing job!

@sonygod
Copy link

sonygod commented Apr 6, 2019

good suggestion +1

@blgrossMS
Copy link

Thank you for the suggestion! We have a proposed architecture #259 that does show how we want to split the classes up easier. We may have some time coming up to implement it!

@pfcDorn
Copy link
Contributor

pfcDorn commented Feb 9, 2024

Please update to the latest version. When you still missing some options, please open a new issue. Thanks!

@pfcDorn pfcDorn closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants