Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Animation Export with Sketchfab's Fork #531

Closed
hybridherbst opened this issue Dec 12, 2019 · 3 comments · Fixed by #644
Closed

Enable Animation Export with Sketchfab's Fork #531

hybridherbst opened this issue Dec 12, 2019 · 3 comments · Fixed by #644

Comments

@hybridherbst
Copy link
Collaborator

Sketchfab's fork of UnityGLTF supports pretty good animation export for nearly two years now, and as far as I know (and from my testing) this repo here still doesn't, which is really unfortunate as it contains many other fixes.

It would be great if the relevant parts that enable animation export are brought over. I messed with it a bit, but are not familiar enough with the details of the file format to get that to work. I might find more time to test but I think it would be much faster to do for someone with more GLTF insight.

Fact is, if you download the unitypackage from https://github.com/sketchfab/UnityGLTF/releases/tag/1.1.0 (you can disable the actual sketchfab upload and log where the GLB is produced), you get properly exported animations in the resulting GLB file.

(for testing, here's sketchfab fork latest with just a simple export button in "Sketchfab/Publish to Sketchfab": https://github.com/prefrontalcortex/UnityGLTF/tree/sketchfab-master)

@hybridherbst
Copy link
Collaborator Author

I opened #533 with what I got over from Sketchfab which seems to work the same as their old fork.

@owilliamailliwo
Copy link
Contributor

Hi, I have created a pull request for support animations and skeleton export.#561 @soraryu

@hybridherbst
Copy link
Collaborator Author

hybridherbst commented Feb 29, 2020

Hey @owilliamailliwo - have you compared in functionality with my PR above? I've also added more features and a ton of stability fixes on my fork - would be great if we can work on getting the best of both!
I'll comment with some questions on your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants