-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Models for checking normal maps #57
Comments
Ignoring morph targets for now, these should be tested by glTF-Asset-Generator but it doesn't right now. We will add them. Morph targets are later in the road map. For now, I have a separate test that we use to test this in Babylon. You can find the assets here: https://github.com/BabylonJS/Website/tree/master/Assets/TestCube. Live view here: http://www.babylonjs.com/demos/gltfnormals/ |
I believe the original NormalTangentTest model handles the last case, as it tests the engine's ability to generate the tangent vectors. A later model was added, NormalTangentMirrorTest that tests the engine's ability to load supplied tangents, which turned out to be less well-supported than generating the tangents. |
@lexaknyazev @bghgary @emackey : Is there a need to keep this open, or should it be transferred to glTF-Sample-Assets repo. Default is to close by 27 Nov. |
I don't know of an example for "MikkTSpace implementation with generated normals" yet. I think the rest of this is resolved. |
This should be transferred. |
PR #88 might help here, as it represents the common workflow of baking normals from a high-resolution model down into a low-resolution model. However it does not contain tangent data. Should it? |
I'd lean toward including the tangents — one less thing a tester needs to worry about, and we have other assets geared specifically toward testing correct handling of missing tangents. |
We need sample models for these cases (+ versions of these with morph targets):
@bghgary Is it something glTF-Asset-Generator could assist with?
The text was updated successfully, but these errors were encountered: