Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☔ Migrate CRDs to kong/kubernetes-configuration repo #6488

Closed
9 tasks done
randmonkey opened this issue Sep 6, 2024 · 3 comments
Closed
9 tasks done

☔ Migrate CRDs to kong/kubernetes-configuration repo #6488

randmonkey opened this issue Sep 6, 2024 · 3 comments
Assignees
Labels
area/CRD Changes in existing CRDs or introduction of new ones area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. epic release/required it is required that this be resolved before releasing
Milestone

Comments

@randmonkey
Copy link
Contributor

randmonkey commented Sep 6, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

Now we have created kong/kubernetes-configuration repository to store CRDs corresponding to Kong configuration. The repo is expected to be shared by KIC and KGO. We need to import source of CRDs from internal packages to packages in kong/kubernetes-configuration.

Proposed Solution

  • Change import source of CRDs to packages in kong/kubernetes-configuration
  • Change the scripts to download CRD manifests from kong/kubernetes-configuration
  • Remove CRD packages and CRD manifests in the repo (Should we do this? Maybe there are dependencies elsewhere)

Additional information

No response

Acceptance Criteria

  • KIC imports CRDs from kong/kubernetes-configuration repo
  • KIC generate manifests from CRDs downloaded from kong/kubernetes-configuration repo
  • Documents mentioning CRD download URLs changed to URLs in kong/kubernetes-configuration

Tasks

Preview Give feedback
  1. area/CRD release/required
    czeslavo
  2. documentation release/required
  3. area/docs release/required
    randmonkey
  4. area/CRD release/required
    randmonkey
  5. area/CRD release/required
    czeslavo
  6. area/CRD release/required
    czeslavo
  7. priority/medium
    programmer04
  8. blocked dependencies
    czeslavo
  9. release/required
    programmer04
@randmonkey randmonkey added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/CRD Changes in existing CRDs or introduction of new ones labels Sep 6, 2024
@randmonkey randmonkey added the release/required it is required that this be resolved before releasing label Oct 21, 2024
@randmonkey
Copy link
Contributor Author

It is required for KGO to operate it.

@czeslavo
Copy link
Contributor

czeslavo commented Oct 30, 2024

We should also take care of handling the control plane reference in KIC and ignore objects that are not attached to other CPs (the default is KIC) OR have the reference non-empty and refer to non-KIC CP.

@lahabana lahabana changed the title Migrate CRDs to kong/kubernetes-configuration repo ☔ Migrate CRDs to kong/kubernetes-configuration repo Nov 6, 2024
@pmalek pmalek added the epic label Dec 10, 2024
@programmer04
Copy link
Member

Every task has been resolved 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CRD Changes in existing CRDs or introduction of new ones area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. epic release/required it is required that this be resolved before releasing
Projects
None yet
Development

No branches or pull requests

4 participants