[Bug]: Navigator tabs ButtonSpecs on Navigator tabs are cut off

[MattH-Work]

Upgraded from 85.24.10.288 to 90.24.11.317, ButtonSpecs on Navigator tabs are cut off

Upper image shows 85.... ( desired ) result ( using a 16 x 16 image for the ButtonSpec)
Lower image shows 90..... ( erroneous ) result ( top row of image is cut, essentially 16 x 15 )

Both tabs are 25 high, nothing else changed during or after toolkit upgrade

[MattH-Work]

Newly added ButtonSpecs show the full image, but it is squashed to 16 x 15

Issue is when ButtonSpec is Styled as List Item ( newly added buttons style as ButtonSpec / Inherited )

[giduac]

Hi @MattH-Work,

Thanks for posting.
I've had a quick look at it but can't reproduce this.

Could you please add a simple project that shows the error?

Thanks.

[MattH-Work]

How would I best go about uploading the solution? it zips to 26mb as it uses both Krypton.toolkit.lite & Krypton.Navigator.Lite, 25 is the git limit

[PWagner1]

How would I best go about uploading the solution? it zips to 26mb as it uses both Krypton.toolkit.lite & Krypton.Navigator.Lite, 25 is the git limit

Is it possible to upload it to DropBox. or if you have Windows 11 24h2 it is possible to compress to 7z?

[MattH-Work]

Now that's too obvious! ( was just wondering if there was any GitHub magic I wasn't aware of )

Here is a link to download a small example of the issue

https://autode.sk/4eFyNfd

[giduac]

Hi @Smurf-IV, @PWagner1,
cc: @MattH-Work

Been doing some testing on this;
The ButtonSpec image does also this on a textbox (probably other controls as well).
In the video it show that several styles produces a different size and make the button move slightly and even resize the textbox in this case.

All styles should be drawn in a rectangle of the same size.
I'd would please have some direction on this as where these buttons / styles are drawn/processed.

B849-UnboundCellCannotSetValue_vhtoT0Kaqu.mp4

[PWagner1]

Hi @giduac

Is it possible to add a 'height' property to button specs?

[Smurf-IV]

I'd would please have some direction on this as where these buttons / styles are drawn/processed.

@giduac try "playing with these settings" in each of the themes:

Also a lot of these will be "Demangled" if I manage to get #1807 done as it is getting quite involved, and will make some of these setting obsolete

[giduac]

@Smurf-IV

This is the problem (-1) at least for list item.
'private static readonly Padding _contentPaddingButtonListItem = new Padding(0, -1, 0, -1);'
and this solves it
' private static readonly Padding _contentPaddingButtonListItem = new Padding(0, 0, 0, 0);'

That would solve this problem.
But for some other states it seems that these paddings vary...

[giduac]

@Smurf-IV

This looks stable even when certain styles use different paddings.
So I will change this one setting for all themes.

What do you think of a size property as a new feature for a ButtonSpec which is handled like this:

        /// <summary>
        /// Gets the content image.
        /// </summary>
        /// <param name="state">The state for which the image is needed.</param>
        /// <returns>Image value.</returns>
        public Image? GetImage(PaletteState state)
        {
            // Get value from button spec passing inheritance redirector
            var baseImage = ButtonSpec.GetImage(_redirector, state);

            // Use the size property to resize the image to the requested size
            if (baseImage is not null)
            {
                baseImage = new Bitmap(baseImage, ButtonSpec.Size);
            }

            // No need to perform scaling as it will be done @
            // $\Standard-Toolkit\Source\Krypton Components\Krypton.Toolkit\Rendering\RenderStandard.cs
            // line 5779: memento.Image = CommonHelper.ScaleImageForSizedDisplay(memento.Image, currentWidth, currentHeight);
            return baseImage;
        }

[giduac]

@Smurf-IV

Maybe just one padding for buttonspecs regardless of the style might be an option for the V100 embedded themes...?
That would keep the size and position equal and the controls won' t be resized on a style change...?

[Smurf-IV]

What do you think of a size property as a new feature for a ButtonSpec which is handled like this:

Not sure, As this will not then following the DPI size changing and might cause even more confusion !

[giduac]

What do you think of a size property as a new feature for a ButtonSpec which is handled like this:

Not sure, As this will not then following the DPI size changing and might cause even more confusion !

OK then that passes.
PRs underway

[PWagner1]

Looks much better!

[giduac]

@PWagner1

That was the intention :).....