Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support path-style of bucket for s3 storage backend #1189

Merged
merged 1 commit into from
Jun 27, 2024
Merged

feat: support path-style of bucket for s3 storage backend #1189

merged 1 commit into from
Jun 27, 2024

Conversation

hoangndst
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Currently, the endpoint of S3 is only in Virtual-hosted–style: https://bucket_name.s3.example.com/. The error will occur if in the case of S3 Storage Server only supports Certificate for Path-Style like https://s3.example.com/bucket_name/

Which issue(s) this PR fixes:

Fixes #1178

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


Copy link

github-actions bot commented Jun 26, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@hoangndst
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9683712546

Details

  • 2 of 9 (22.22%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 54.157%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/api.kusion.io/v1/types.go 0 2 0.0%
pkg/config/validation.go 1 6 16.67%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/destroy.go 7 49.82%
Totals Coverage Status
Change from base Build 9658530204: -0.06%
Covered Lines: 9106
Relevant Lines: 16814

💛 - Coveralls

@liu-hm19
Copy link
Contributor

@hoangndst Thank you very much for submitting this pull request! This PR looks good to me, but it didn't pass the Commit Lint check. We would appreciate it if you could update the commit message in the following format and push it again.

# reset the commit
git reset --soft HEAD^

# update the commit message
git commit -m "feat: force path-style"

# force push to the remote branch
git push [remote-repo] s3-path-style:s3-path-style -f

@liu-hm19 liu-hm19 self-requested a review June 27, 2024 03:16
@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Jun 27, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jun 27, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks a lot for submitting this pull request! Please update the commit message and push the branch again to pass the Commit Lint check.

@SparkYuan
Copy link
Member

@hoangndst Thank you very much for your contribution! Welcome to the community!

@liu-hm19 liu-hm19 merged commit f35d744 into KusionStack:main Jun 27, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Support Path-Style of bucket for s3 Storage backend
4 participants