Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support release unlock command #1191

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR supports the kusion release unlock command to unlock the phase in release file of the current stack, solving the concurrent read-write problem.

Which issue(s) this PR fixes:

Fixes #1168

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Jun 27, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jun 27, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan June 27, 2024 07:27
@liu-hm19 liu-hm19 self-assigned this Jun 27, 2024
@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9692447838

Details

  • 76 of 100 (76.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 54.436%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd.go 0 6 0.0%
pkg/cmd/release/unlock.go 63 71 88.73%
pkg/engine/release/util.go 0 10 0.0%
Totals Coverage Status
Change from base Build 9692204146: 0.4%
Covered Lines: 9234
Relevant Lines: 16963

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9692593094

Details

  • 76 of 100 (76.0%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 54.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd.go 0 6 0.0%
pkg/cmd/release/unlock.go 63 71 88.73%
pkg/engine/release/util.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.61%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
Totals Coverage Status
Change from base Build 9692204146: 0.3%
Covered Lines: 9227
Relevant Lines: 16963

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9710612028

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 75 of 99 (75.76%) changed or added relevant lines in 4 files are covered.
  • 241 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.2%) to 54.258%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd.go 0 6 0.0%
pkg/cmd/release/unlock.go 62 70 88.57%
pkg/engine/release/util.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/destroy.go 7 49.82%
pkg/config/validation.go 10 75.65%
pkg/apis/api.kusion.io/v1/types.go 14 0.0%
pkg/engine/operation/graph/resource_node.go 38 55.56%
pkg/engine/runtime/terraform/terraform_runtime.go 46 40.64%
pkg/engine/runtime/terraform/tfops/workspace.go 126 59.1%
Totals Coverage Status
Change from base Build 9692204146: 0.2%
Covered Lines: 9251
Relevant Lines: 17050

💛 - Coveralls

@liu-hm19 liu-hm19 force-pushed the support-release-unlock branch from 67984c1 to 2eadd91 Compare June 28, 2024 09:49
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit bbba628 into KusionStack:main Jun 28, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: implement kusion release unlock command
3 participants