Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit content width on larger screens #20

Open
IngridRegina opened this issue Aug 30, 2021 · 0 comments
Open

Limit content width on larger screens #20

IngridRegina opened this issue Aug 30, 2021 · 0 comments
Assignees

Comments

@IngridRegina
Copy link
Collaborator

IngridRegina commented Aug 30, 2021

I think 1800px would be ok for max-width. Basically if we would only limit the width of the hero carousel, it would look weird since everything else would still be full width. So we need to:

  • max-width: 1800px and margin: 0 auto to c-slider, c-header, c-footer
  • add max-width: 1800px, background-color: #1e1e1e (white background is already taken care of) and margin: 0 auto to c-section as well
  • probably need to override the c-section background color for footer, best to create an "--orange" modifier for c-section
  • possibly something else that I'm missing, check if everything looks okay with google developer tools (choose "responsive" from the device toolbar and insert some bigger ratio)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants